[TASK] Implement Value::getArrayRepresentation() - #1480
Merged
Conversation
This implementation might get removed if all subclasses have their own implementation without needing the parent class implementation. Part of #1440.
oliverklee
added
testing
JakeQZ
approved these changes
Jan 25, 2026
JakeQZ
left a comment
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
Descendent classes could call this parent method and merge the array, so they don't have make the getShortClassName() call themselves. Though the current implementations are, of course, not doing that (yet).
I wondered whether this would lead to an incomplete implementation in descendent classes where the method has not yet been implemented, but
- I don't think that matters;
- All descendent classes I checked have their own stub method throwing an exception, or an actual implementation.
This is a somewhat redundant change at the moment, until any descendent classes use parent::getArrayRepresentation(), but is nonetheless good for completeness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation might get removed if all subclasses have their own implementation without needing the parent class implementation.
Part of #1440.